Deposit form: Provide props to overridable components #2807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the
<Overridable>
components have been using values that weren't passed as props.This makes it hard to provide overrides for those components that are functionally the same.
For example, I am writing an override for the
InvenioAppRdm.Deposit.CardDepositStatusBox.container
forInvenio-Curations
which adds a section for the curation review request.Without passing the props, this override couldn't access the
props.permissions
which is used by the default component to enable/disable some buttons.With the props being passed, I can use it as expected: